This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
add domain representations #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
force-pushed
the
domain-reps
branch
2 times, most recently
from
d59e82d to
4e68513
Compare
steve-chavez
force-pushed
the
domain-reps
branch
from
4e68513 to
a89eebe
Compare
aljungberg
reviewed
Jun 29, 2023
Co-authored-by: Alexander Ljungberg <[email protected]>
aljungberg
suggested changes
Jun 30, 2023
| Domain Representations | ||
| ###################### | ||
|
|
||
| Domain Representations separates "how the data is presented" from "how the data is stored". It works by creating `domains <https://www.postgresql.org/docs/current/sql-createdomain.html>`_ and `casts <https://www.postgresql.org/docs/current/sql-createcast.html>`_, the latter act on the former to present and receive the data in different formats. |
There was a problem hiding this comment.
Nicely done! I struggled with coming up with a concise way to describe the feature.
There was a problem hiding this comment.
Thanks! Actually I stole some phrases from your opening issue 😃
I wanted to remove the "latter/former" words but I found it hard. Although it seems ok leaving it this way.
I've just addressed your latest reviews. LMK if you approve and I'll merge 🚀.
There was a problem hiding this comment.
Also clarified the advantages (focusing on views) and "why not create a type?".
Co-authored-by: Alexander Ljungberg <[email protected]>
Co-authored-by: Alexander Ljungberg <[email protected]>
Co-authored-by: Alexander Ljungberg <[email protected]>
Co-authored-by: Alexander Ljungberg <[email protected]>
Co-authored-by: Alexander Ljungberg <[email protected]>
this way it can be seen at the beggining there are advantages over views and computed fields.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PostgREST/postgrest#2839
Rendered doc.