nix: more explicit logging in load test #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only fixes #2308 in so far as making the build failure explicit, but I'm okay with that for now. |
|
Yes, that's much better. As proposed in #2308 I suggest we keep the issue open to run the loadtest conditionally later on. Maybe we just need to add some condition that a failure of the loadtest is fine. We don't have an automated evaluation of the loadtest results so far anyway - so the only failure mode is when the test itself didn't succeed. |
wolfgangwalther
approved these changes
Jun 9, 2022
* Write vegeta output to file explicitly. The previous version using `tee` captured the standard output of the `withPgrst` helper, too, causing weird errors when those had unexpected output. * Log and fail the postgrest build explicitly. In situations such as changing nix dependencies, the `cabal build` run could fail, but this wasn't visible in CI. With these changes, the load test now fails with a nice error message when the build fails.
robx
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write vegeta output to file explicitly.
The previous version using
teecaptured the standardoutput of the
withPgrsthelper, too, causing weirderrors when those had unexpected output.
Log and fail the postgrest build explicitly.
In situations such as changing nix dependencies, the
cabal buildrun could fail, but this wasn't visiblein CI.
With these changes, the load test now fails with a nice
error message when the build fails.