feat: add max-affected preference to prefer header #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steve-chavez I am not sure if we need to test this with batch upserts because that would involve the |
|
@taimoorzaeem Yeah, I think it's fine to not do POST/Upsert This feature can be like the strict counterpart of Limited Update/Delete. |
steve-chavez
reviewed
Dec 5, 2023
Comment on lines
123
to
156
| context "test Prefer: max-affected" $ do | ||
| it "should fail if items deleted more than 10" $ | ||
| request methodDelete "/items?id=lt.15" | ||
| [("Prefer", "handling=strict, max-affected=10")] | ||
| "" | ||
| `shouldRespondWith` | ||
| [json|{"code":"PGRST124","details":"The query affects 14 rows","hint":null,"message":"Query result exceeds max-affected preference constraint"}|] | ||
| { matchStatus = 400 } | ||
|
|
||
| it "should succeed if items deleted less than 10" $ | ||
| request methodDelete "/items?id=lt.10" | ||
| [("Prefer", "handling=strict, max-affected=10")] | ||
| "" | ||
| `shouldRespondWith` | ||
| "" | ||
| { matchStatus = 204 | ||
| , matchHeaders = ["Preference-Applied" <:> "handling=strict, max-affected=10"]} | ||
|
|
||
| -- tests batch upserts? | ||
| it "should fail if items updated more than 0" $ | ||
| request methodPatch "/tiobe_pls?name=eq.Java" | ||
| [("Prefer", "handling=strict, max-affected=0")] | ||
| [json| [{"name":"Java", "rank":19}] |] | ||
| `shouldRespondWith` | ||
| [json|{"code":"PGRST124","details":"The query affects 1 rows","hint":null,"message":"Query result exceeds max-affected preference constraint"}|] | ||
| { matchStatus = 400 } | ||
|
|
||
| it "should succeed if items updated equal 1" $ | ||
| request methodDelete "/tiobe_pls?name=eq.Java" | ||
| [("Prefer", "handling=strict, max-affected=1")] | ||
| [json| [{"name":"Java", "rank":19}] |] | ||
| `shouldRespondWith` | ||
| "" | ||
| { matchStatus = 204 | ||
| , matchHeaders = ["Preference-Applied" <:> "handling=strict, max-affected=1"]} |
There was a problem hiding this comment.
Would be good to have a test case for handling=lenient and no handling to make sure we don't err in that case.
taimoorzaeem
force-pushed
the
prefer/affected
branch
from
46c2c77 to
a35133e
Compare
| , matchHeaders = ["Preference-Applied" <:> "handling=strict, max-affected=1"]} | ||
|
|
||
| context "test Prefer: max-affected with handling=lenient" $ do | ||
| it "should fail if items deleted more than 10" $ |
There was a problem hiding this comment.
it should be succeed here right?
| { matchStatus = 204 | ||
| , matchHeaders = ["Preference-Applied" <:> "handling=lenient"]} | ||
|
|
||
| it "should fail if items updated more than 0" $ |
taimoorzaeem
force-pushed
the
prefer/affected
branch
from
a35133e to
121bcb0
Compare
taimoorzaeem
force-pushed
the
prefer/affected
branch
from
121bcb0 to
01205fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2887.