Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable in-database configuration for pool settings #3137

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laurenceisla
Copy link
Member

Closes #3110.

@laurenceisla laurenceisla changed the title feat: add in-database configuration for pool settings feat: enable in-database configuration for pool settings Dec 28, 2023
@laurenceisla
Copy link
Member Author

@steve-chavez

Managed to make it reload the pool configurations, but I'm not very familiarized with the process: I'm not sure if it needs to destroy the old pool or where. For example, I have doubts on what would happen here:

bracket
(AppState.init conf)
AppState.destroy

I'm also not familiarized with the debWorker and if it needs to be updated too.

On a side note, I added a test that checks if the db-pool configuration is reloaded correctly. It fails in the main branch.... although now, the test_no_pool_connection_available is failing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Enable in-database configuration for pool settings
1 participant