Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: control tabel/view currentuser insert, update,delete rights #3685

Closed
wants to merge 6 commits into from

Conversation

jyritali
Copy link

@jyritali jyritali commented Aug 8, 2024

Closes #3684

feature: control tabel/view currentuser insert, update,delete rights.
add to PostgREST - user tabel and view rights control and show methods reagarding user rights, not table or view one

@jyritali
Copy link
Author

jyritali commented Aug 8, 2024

Please merge these commits to one commit

@laurenceisla
Copy link
Member

laurenceisla commented Aug 8, 2024

I remember tackling this in PR #1824, we had the following discussion there: #1824 (comment)

In summary, the HTTP methods returned by OPTIONS show what CAN be done to the table/view, not the privileges granted to them.

-- The following fields identify what can be done on the table/view, they're not related to the privileges granted to it
, tableInsertable :: Bool
, tableUpdatable :: Bool
, tableDeletable :: Bool

This may be different for OpenAPI though, but we didn't follow up with it because we were in the plans of removing it from the core repo.

All in all, thanks for the initiative, but these changes are not compatible with what we agreed in the PR I mentioned.

@wolfgangwalther
Copy link
Member

I remember tackling this in PR #1824, we had the following discussion there: #1824 (comment)

Right, note specifically this comment by Steve where he makes the distinction between "allowed" and "valid". OPTIONS is about "valid", so we're not going to do the change proposed in this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

new feature - control tables/views currentuser insert, delete. update rights
3 participants