Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: fix CI pipeline for XDP packages #11

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

romeroalx
Copy link
Member

Package libxdp-dev is available from the backports repository for Debian Bullseye.

Use a more recent version of actions to avoid warnings related to Nodejs 16.

Test PDNS build-and-test-all workflow - Debian 12: https://github.com/romeroalx/pdns/actions/runs/7728319018

Test PDNS build-and-test-all workflow - Debian 11: https://github.com/romeroalx/pdns/actions/runs/7728319010

@romeroalx
Copy link
Member Author

Hi @rgacogne, in this repository, we build images for Debian 11 and 12 that later are used by the PDNS workflow build-and-test-all, although we no longer use 11 in master (only in the branch real/rec-5.0.0, almost sure).

In this PR, I am proposing to add the repository backports for installing the new xdp packages, but I am not sure if it is better to just set skipXDP=True for the Debian 11 build. Do you have any preference?

@romeroalx romeroalx requested a review from rgacogne February 1, 2024 06:09
@rgacogne
Copy link
Member

rgacogne commented Feb 1, 2024

Thanks for looking into this!

In this PR, I am proposing to add the repository backports for installing the new xdp packages, but I am not sure if it is better to just set skipXDP=True for the Debian 11 build. Do you have any preference?

Is there anything broken at the moment? I tried to be careful about not breaking anything, and disabled XDP support for the workflows using an image without xdp (misc-dailies.yml and codeql-analysis.yml which are running ubuntu-22.04). I'm afraid it's not clear to me where we use Debian 11 to build/test dnsdist?

@romeroalx
Copy link
Member Author

Thank you for your answer, @rgacogne

To give you more context, we build docker images with pre-installed packages that are common for the workflow build-and-test-all in PowerDNS/pdns - master. We do this using Debian 11 and Debian 12 as the base image.

Two days ago, the runs started failing for the build based on Debian 11: run.

As part of the build done, the function install_dnsdist_build_deps is called as can be seen here. In this function, XDP packages are installed if not set otherwise but are not used further.

Hope it clarifies this :)

@rgacogne
Copy link
Member

rgacogne commented Feb 1, 2024

Thanks, that's indeed the part I was missing :) Sorry about not seeing that coming!
I think the best option would be to stop calling install-dnsdist-build-deps for the Debian 11 image since we do not use for anything dnsdist-related, as far as I can tell? Otherwise setting skipXDP=True looks good as well.

@romeroalx romeroalx force-pushed the add-debian-backports branch from 58da18c to b678dce Compare February 1, 2024 12:25
@romeroalx romeroalx force-pushed the add-debian-backports branch from b678dce to 6e3d9f1 Compare February 1, 2024 13:38
@romeroalx romeroalx merged commit 73db86b into PowerDNS:image-debian-11 Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants