Merge pull request #14792 from rgacogne/ddist-coverity-202410

dnsdist: Fix Coverity warning 445614: " Argument cannot be negative"
PowerDNS · Nov 4, 2024 · 4a65f56 · 4a65f56
2 parents 021f88f + 34e86b2
commit 4a65f56
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pdns/dnsdistdist/dnsdist-cache.cc b/pdns/dnsdistdist/dnsdist-cache.cc
@@ -484,7 +484,11 @@ uint64_t DNSDistPacketCache::getEntriesCount()
 
 uint64_t DNSDistPacketCache::dump(int fileDesc, bool rawResponse)
 {
-  auto filePtr = pdns::UniqueFilePtr(fdopen(dup(fileDesc), "w"));
+  auto fileDescDuplicated = dup(fileDesc);
+  if (fileDescDuplicated < 0) {
+    return 0;
+  }
+  auto filePtr = pdns::UniqueFilePtr(fdopen(fileDescDuplicated, "w"));
   if (filePtr == nullptr) {
     return 0;
   }