Merge pull request #13304 from rgacogne/ddist-async-unit-tests-rae

dnsdist: Fix a race in the Async unit tests
PowerDNS · Oct 2, 2023 · 9a2f8d7 · 9a2f8d7
2 parents 727bb9c + f39b15a
commit 9a2f8d7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pdns/dnsdistdist/test-dnsdistasync.cc b/pdns/dnsdistdist/test-dnsdistasync.cc
@@ -49,7 +49,7 @@ class DummyQuerySender : public TCPQuerySender
     errorRaised = true;
   }
 
-  bool errorRaised{false};
+  std::atomic<bool> errorRaised{false};
 };
 
 struct DummyCrossProtocolQuery : public CrossProtocolQuery
@@ -137,7 +137,7 @@ BOOST_AUTO_TEST_CASE(test_TimeoutFailClose)
   }
 
   BOOST_CHECK(holder->empty());
-  BOOST_CHECK(sender->errorRaised);
+  BOOST_CHECK(sender->errorRaised.load());
 
   holder->stop();
 }
@@ -170,7 +170,7 @@ BOOST_AUTO_TEST_CASE(test_AddingExpiredEvent)
   }
 
   BOOST_CHECK(holder->empty());
-  BOOST_CHECK(sender->errorRaised);
+  BOOST_CHECK(sender->errorRaised.load());
 
   holder->stop();
 }