Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist-1.8.x: Add a DynBlockRulesGroup:removeRange() binding #13601

Merged
merged 3 commits into from
Dec 14, 2023
Merged

dnsdist-1.8.x: Add a DynBlockRulesGroup:removeRange() binding #13601

merged 3 commits into from
Dec 14, 2023

Conversation

rgacogne
Copy link
Member

Short description

Backport of #13342 to rel/dnsdist-1.8.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne
dnsdist: Add a DynBlockRulesGroup:removeRange() binding
482274c 
This adds the ability to remove an existing range from the list of
existing included/excluded ranges.

(cherry picked from commit 59a8b33)
@rgacogne
dnsdist: Fix version in the documentation of DynBlockRulesGroup:remov…
709c25b 
…eRange()

(cherry picked from commit f44613e)
@rgacogne
dnsdist: Disable the complexity check for setupLuaInspection()
9a975b7 
(cherry picked from commit cbf61a8)
@rgacogne rgacogne added this to the dnsdist-1.8.x milestone Dec 12, 2023
chbruyand
chbruyand approved these changes Dec 14, 2023
View reviewed changes
pdns/dnsdistdist/docs/reference/config.rst
@@ -1614,6 +1614,14 @@ faster than the existing rules.

:param list netmasks: A :class:`NetmaskGroup` object, or a netmask or list of netmasks as strings, like for example "192.0.2.1/24"

.. method:: DynBlockRulesGroup:removeRange(netmasks)

.. versionadded:: 1.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8.1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8.3, if I'm not mistaken, but we will have to fix this in master since the documentation on stable branches is not used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant 1.8.x :/ sorry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13622

@rgacogne rgacogne merged commit 295fea8 into PowerDNS:rel/dnsdist-1.8.x Dec 14, 2023
10 checks passed
@rgacogne rgacogne deleted the ddist18-13342 branch December 14, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.x
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @chbruyand