Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coverity to a reusable workflow, add a dispatcher workflow #14580

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rgacogne
Copy link
Member

Short description

I need to find a way to test this, but review and comments welcome in the meantime :)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Aug 22, 2024

Pull Request Test Coverage Report for Build 10956306354

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.678%

Files with Coverage Reduction New Missed Lines %
ext/json11/json11.cpp 1 64.49%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/syncres.cc 1 79.54%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/recursordist/aggressive_nsec.cc 2 65.88%
pdns/misc.cc 2 63.26%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/opensslsigners.cc 5 61.07%
Totals Coverage Status
Change from base Build 10939216509: 0.02%
Covered Lines: 124811
Relevant Lines: 162220

💛 - Coveralls

Copy link
Member

@romeroalx romeroalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You may see some tests below:

@rgacogne
Copy link
Member Author

Wonderful, thank you for testing!

@rgacogne rgacogne merged commit cf7d385 into PowerDNS:master Sep 20, 2024
79 checks passed
@rgacogne rgacogne deleted the fix-coverity branch September 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants