auth: allow turning off across-zone resolving #14604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideas on how to add regression-tests welcome. |
Pull Request Test Coverage Report for Build 11065599865Details
💛 - Coveralls |
zeha
force-pushed
the
zeha-10017-cname-follow-config
branch
from
033c2a4
to
67cb459
Compare
Is there currently some code in PDNS to follow SVCB? SVCB ist quite different as the client application needs to perform the resolving. But IMO PDNS should not provide hints out of bailiwik, regardless if CNAME, DNAME, SVCB/HTTPS, NS .... |
SVCB was taken care of by #10521 |
zeha
force-pushed
the
zeha-10017-cname-follow-config
branch
2 times, most recently
from
308ca1e
to
c724660
Compare
zeha
changed the title
zeha
force-pushed
the
zeha-10017-cname-follow-config
branch
from
c724660
to
26d9e11
Compare
mind04
reviewed
Sep 26, 2024
Default is unchanged. Turning off the new setting causes CNAME targets to not be followed across (local) zones. Also, queries that could be answered by following a local delegations are similarly not resolved.
zeha
force-pushed
the
zeha-10017-cname-follow-config
branch
from
26d9e11
to
b031eeb
Compare
|
Also added regression test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Addresses #10017. Introduces new setting
resolve-across-zones. Default is the unchanged behaviour.Turning off the new setting causes CNAME targets to not be followed across (local) zones. Also, queries that could be answered by following a local delegation are similarly not resolved.
Checklist
I have: