Cleanups to lmdb source files

[fredmorcos]

Short description

Some cleanup to lmdb source files, the 128-bit IDs branch is getting more complicated so I want to merge commits that can be made independent:

• Formatting and lint cleanups
• Renames serToString and serFromString to serializeToBuffer and deserializeFromBuffer
• Rename the LMDBIDVec
• Clean up source code comments

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[fredmorcos]

The code formatting failure is a clang-format version difference. This old version doesn't understand the much much genius operator& overloading that boost is doing for the Archive type. I think we can just force-merge this until we update our clang-format.

[coveralls]

Pull Request Test Coverage Report for Build 10690059003

Details

• 86 of 89 (96.63%) changed or added relevant lines in 3 files are covered.
• 8566 unchanged lines in 90 files lost coverage.
• Overall coverage decreased (-2.0%) to 62.681%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/lmdbbackend/lmdbbackend.cc	68	69	98.55%
ext/lmdb-safe/lmdb-typed.hh	15	17	88.24%

Files with Coverage Reduction	New Missed Lines	%
modules/gpgsqlbackend/gpgsqlbackend.cc	1	88.62%
pdns/epollmplexer.cc	2	83.13%
pdns/libssl.hh	2	0.0%
ext/yahttp/yahttp/utility.hpp	2	36.53%
pdns/burtle.hh	2	97.55%
pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc	2	0.0%
pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc	2	0.0%
pdns/channel.hh	2	45.89%
pdns/pollmplexer.cc	2	83.01%
pdns/proxy-protocol.cc	2	84.93%

Totals
Change from base Build 10685140594:	-2.0%
Covered Lines:	104017
Relevant Lines:	143876

---

💛 - Coveralls

[Habbie]

I think we can just force-merge this until we update our clang-format.

I suppose this means that clang-format will be unhappy for future PRs that touch the same area (until that update)?

[fredmorcos]

I suppose this means that clang-format will be unhappy for future PRs that touch the same area (until that update)?

I will undo this commit and fix the clang-tidy complaints once I figure out why clang-tidy warnings stopped showing up in my editor.