Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist-1.9.x: Backport 14570 - Return a valid unix timestamp for Dynamic Block's until #14643

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Sep 9, 2024

Short description

Backport of #14570 to dnsdist-1.9.x.

We internally use a timestamp obtained via CLOCK_MONOTONIC which is quite useless to an external observer, so convert it to a normal unix timestamp in the Lua accessor.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

We internally use a timestamp obtained via `CLOCK_MONOTONIC` which
is quite useless to an external observer, so convert it to a normal
unix timestamp in the Lua accessor.

(cherry picked from commit 8cb758a)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10774948845

Details

  • 2 of 19 (10.53%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 55.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdist-lua-inspection.cc 2 19 10.53%
Files with Coverage Reduction New Missed Lines %
pdns/dnscrypt.cc 1 68.07%
pdns/iputils.hh 2 75.0%
pdns/misc.cc 2 40.18%
pdns/dnsdistdist/dnsdist-async.cc 2 82.21%
Totals Coverage Status
Change from base Build 9987810845: -0.02%
Covered Lines: 47997
Relevant Lines: 65527

💛 - Coveralls

@rgacogne rgacogne merged commit a61151f into PowerDNS:rel/dnsdist-1.9.x Sep 10, 2024
12 checks passed
@rgacogne rgacogne deleted the ddist-19-backport-14570 branch September 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants