Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist-1.9.x: Backport 14569 - Fix EDNS flags confusion when editing the OPT header #14644

Merged

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Sep 9, 2024

Short description

Backport of #14569 to dnsdist-1.9.x

We used to wrongly reverse the byte-ordering of the existing EDNS flags when editing the OPT header, for example when setting an extended DNS error status.

(cherry picked from commit 010521a)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

We used to wrongly reverse the byte-ordering of the existing EDNS
flags when editing the OPT header, for example when setting an
extended DNS error status.

(cherry picked from commit 010521a)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10775159815

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 55.784%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-async.cc 2 82.21%
pdns/dnsdist-tcp.cc 8 75.83%
Totals Coverage Status
Change from base Build 9987810845: -0.009%
Covered Lines: 47995
Relevant Lines: 65509

💛 - Coveralls

@rgacogne rgacogne merged commit 57068f7 into PowerDNS:rel/dnsdist-1.9.x Sep 10, 2024
12 checks passed
@rgacogne rgacogne deleted the ddist19-backport-14569 branch September 10, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants