Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist-1.9.x: Backport 14534 - Add warnings about large values passed to setMaxTCPClientThreads #14646

Merged

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Sep 9, 2024

Short description

Backport of #14534 to dnsdist-1.9.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10775298575

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • 4207 unchanged lines in 84 files lost coverage.
  • Overall coverage decreased (-0.02%) to 55.775%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdist.cc 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
pdns/qtype.hh 1 50.0%
pdns/dnsdistdist/test-dnsdisttcp_cc.cc 1 94.97%
pdns/epollmplexer.cc 2 77.71%
pdns/libssl.hh 2 0.0%
pdns/dnsdist-lua-bindings-dnsquestion.cc 2 36.0%
pdns/burtle.hh 2 96.32%
pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc 2 26.0%
pdns/views.hh 2 42.11%
pdns/dnscrypt.hh 2 33.33%
pdns/pollmplexer.cc 2 82.39%
Totals Coverage Status
Change from base Build 9987810845: -0.02%
Covered Lines: 47996
Relevant Lines: 65513

💛 - Coveralls

@rgacogne rgacogne merged commit c0d3b04 into PowerDNS:rel/dnsdist-1.9.x Sep 10, 2024
13 checks passed
@rgacogne rgacogne deleted the ddist19-backport-14534 branch September 10, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants