Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: rust related updates #14653

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

omoerbeek
Copy link
Member

Short description

  1. Update rust version to 1.81.0
  2. Start using serde_yml as a replacement for serde_yaml (a few tests needed update as the quoting rules on output changed).
  3. Update Cargo.lock

I seems serde_yml (the fork) is actively maintained. A large part of the activity is adding unit test, so that feels good so far.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10809095251

Details

  • 30 of 30 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1828 unchanged lines in 61 files lost coverage.
  • Overall coverage decreased (-0.2%) to 64.511%

Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 66.33%
pdns/validate.cc 1 68.19%
pdns/dnstap.cc 2 70.97%
pdns/cachecleaner.hh 2 79.79%
ext/luawrapper/include/LuaContext.hpp 2 13.45%
pdns/ws-api.cc 2 84.91%
pdns/lock.hh 2 84.71%
pdns/unix_utility.cc 3 43.78%
pdns/epollmplexer.cc 3 83.13%
pdns/sstuff.hh 3 56.2%
Totals Coverage Status
Change from base Build 10793790851: -0.2%
Covered Lines: 124599
Relevant Lines: 162255

💛 - Coveralls

@omoerbeek
Copy link
Member Author

Spotted a YAML conversion issue while working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants