Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a "too large" counter for the framestream remote logger #14666

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

omoerbeek
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added this to the common-soon milestone Sep 13, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10844927658

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • 88 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+3.4%) to 64.685%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/fstrm_logger.cc 0 1 0.0%
pdns/fstrm_logger.hh 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/recursor_cache.cc 1 86.0%
pdns/backends/gsql/gsqlbackend.hh 2 96.57%
pdns/rcpgenerator.cc 2 89.95%
pdns/packethandler.cc 4 72.47%
pdns/misc.cc 4 63.2%
pdns/recursordist/taskqueue.cc 11 34.15%
modules/lmdbbackend/lmdbbackend.cc 14 72.5%
pdns/recursordist/syncres.cc 15 79.66%
pdns/recursordist/rec-taskqueue.cc 34 40.14%
Totals Coverage Status
Change from base Build 10843570514: 3.4%
Covered Lines: 124827
Relevant Lines: 162271

💛 - Coveralls

@omoerbeek omoerbeek merged commit d3c49eb into PowerDNS:master Sep 13, 2024
79 checks passed
@omoerbeek omoerbeek deleted the fstrm-too-large-cout branch September 13, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants