Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH actions: skip job build-auth with meson for Debian 11 #14674

Merged

Conversation

romeroalx
Copy link
Contributor

Short description

The weekly-scheduled workflow build-and-test-all-releases-dispatch.yml has been failing for quite some time because the version of the ldap library that is installed for Debian 11 does not have the file ldap.pc, and therefore meson is not able to find the library (see run). This has been solved in newer versions like the one that can be installed in Debian 12.

This PR changes the definition of the matrix for the job build-auth in build-and-test-all.yaml to skip the case for building auth with meson on Debian 11.

NOTE: Adding the exclude cause was insufficient because it is evaluated before the clause include in a matrix definition. Also, these clauses (include/exclude) do not support matching against dictionaries.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10881507322

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 53 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.01%) to 64.668%

Files with Coverage Reduction New Missed Lines %
ext/lmdb-safe/lmdb-typed.hh 1 73.6%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/misc.hh 3 87.62%
pdns/tsigverifier.cc 3 77.22%
pdns/fstrm_logger.cc 3 44.08%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/dnsdistdist/dnsdist.cc 4 68.36%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.89%
pdns/recursordist/syncres.cc 6 79.51%
pdns/misc.cc 6 63.15%
Totals Coverage Status
Change from base Build 10881391740: -0.01%
Covered Lines: 124807
Relevant Lines: 162273

💛 - Coveralls

@fredmorcos fredmorcos merged commit 5e348b3 into PowerDNS:master Sep 16, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants