New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth 4.9 API: when querying with rrset_name, respect it for comments too #14675

Open

Habbie wants to merge 1 commit into PowerDNS:rel/auth-4.9.x from Habbie:backport-14045-to-auth-4.9.x

Member

Habbie commented Sep 16, 2024

Short description

backport of #14045

Checklist

I have:

read the CONTRIBUTING.md document
compiled this code
tested this code
included documentation (including possible behaviour changes)
documented the code
added or modified regression test(s)
added or modified unit test(s)
checked that this code was merged to master


          auth API: when querying with rrset_name, respect it for comments too

ab357bd

(cherry picked from commit e8e31cd)

coveralls commented Sep 16, 2024

Pull Request Test Coverage Report for Build 10881997870

Details

8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
29 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.02%) to 63.171%

Files with Coverage Reduction	New Missed Lines	%
pdns/misc.hh	3	76.0%
pdns/tsigverifier.cc	3	77.22%
pdns/rcpgenerator.cc	3	90.14%
modules/gpgsqlbackend/spgsql.cc	3	67.7%
pdns/signingpipe.cc	5	85.48%
ext/lmdb-safe/lmdb-safe.hh	6	62.12%
ext/lmdb-safe/lmdb-safe.cc	6	74.47%

Totals
Change from base Build 10594348070:	-0.02%
Covered Lines:	41769
Relevant Lines:	59384

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet