Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Update ChangeLog and secpoll for 1.8.4 #14687

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

rgacogne
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.x milestone Sep 19, 2024
@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10940995304

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.03%) to 64.682%

Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/lwres.cc 1 69.8%
pdns/misc.cc 2 63.2%
pdns/remote_logger.cc 3 54.26%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
modules/godbcbackend/sodbc.cc 4 70.8%
pdns/recursordist/test-syncres_cc1.cc 7 89.55%
pdns/recursordist/rec-tcp.cc 10 64.87%
Totals Coverage Status
Change from base Build 10939216509: 0.03%
Covered Lines: 124786
Relevant Lines: 162215

💛 - Coveralls

Habbie
Habbie previously requested changes Sep 19, 2024
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits, otherwise good, agreed on all the PRs left out of this

pdns/dnsdistdist/docs/changelog.rst Outdated Show resolved Hide resolved
pdns/dnsdistdist/docs/changelog.rst Outdated Show resolved Hide resolved
@rgacogne
Copy link
Member Author

Rebased on master to get the new version of the mssql image in our CI.

@rgacogne rgacogne dismissed Habbie’s stale review September 20, 2024 11:02

Fixed in the meantime

@rgacogne rgacogne merged commit 98863d5 into PowerDNS:master Sep 20, 2024
79 checks passed
@rgacogne rgacogne deleted the ddist-changelog-secpoll-1.8.4 branch September 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants