-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: implement rfc6303 special zones (mostly v6 reverse mappings) #14693
Conversation
Pull Request Test Coverage Report for Build 11213595982Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
log->info(Logr::Notice, "Inserting rfc 6303 private space zones")); | ||
// Section 4.2 | ||
makePartialIPZone(*newMap, {"0"}, log); | ||
// makePartialIPZone(*newMap, { "127" }, log) already done in processServeRFC1918 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we okay with what happens if serve-rfc6303
is enabled but serve-rfc1918
is not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into that. Easiest thing would be to forbid that.
Updates #8679. :D |
Short description
Guarded by a
recursor.serve_rfc6303
setting, defaulttrue
.Requested by @neilcook
Checklist
I have: