Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: implement rfc6303 special zones (mostly v6 reverse mappings) #14693

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

omoerbeek
Copy link
Member

Short description

Guarded by a recursor.serve_rfc6303 setting, default true.

Requested by @neilcook

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 11213595982

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 27 of 33 (81.82%) changed or added relevant lines in 2 files are covered.
  • 5531 unchanged lines in 74 files lost coverage.
  • Overall coverage increased (+0.002%) to 64.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/reczones.cc 21 27 77.78%
Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 69.16%
pdns/recursordist/ext/protozero/include/protozero/config.hpp 1 0.0%
pdns/recursordist/sortlist.hh 1 75.0%
pdns/iputils.hh 1 78.25%
pdns/dnstap.cc 2 70.97%
ext/probds/murmur3.cc 2 94.12%
pdns/sstuff.hh 2 56.83%
pdns/dnsname.hh 2 91.84%
pdns/recursordist/secpoll-recursor.cc 2 51.02%
pdns/rcpgenerator.cc 2 90.05%
Totals Coverage Status
Change from base Build 11213210825: 0.002%
Covered Lines: 125039
Relevant Lines: 162466

💛 - Coveralls

pdns/recursordist/settings/table.py Outdated Show resolved Hide resolved
log->info(Logr::Notice, "Inserting rfc 6303 private space zones"));
// Section 4.2
makePartialIPZone(*newMap, {"0"}, log);
// makePartialIPZone(*newMap, { "127" }, log) already done in processServeRFC1918
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we okay with what happens if serve-rfc6303 is enabled but serve-rfc1918 is not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into that. Easiest thing would be to forbid that.

pdns/recursordist/reczones.cc Outdated Show resolved Hide resolved
@omoerbeek omoerbeek merged commit 659cd44 into PowerDNS:master Oct 7, 2024
78 checks passed
@omoerbeek omoerbeek deleted the rec-rfc6303 branch October 7, 2024 12:32
@mnordhoff
Copy link
Contributor

Updates #8679. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants