rec: rpz tweaks and do not apply rpz-nsdname and rpz-nsip to forwarders

[omoerbeek]

Short description

• Log policyname on policyHit when updating root
• Do not register invalid file-based RPZs
• Do not return null SOA (this should no longer happen with the 2nd bullet, but better safe than sorry)

2nd commit: do not apply NS based policies to (recursive) forwarders. This commit is debatable, hence draft status.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 10955087378

Details

• 5 of 14 (35.71%) changed or added relevant lines in 3 files are covered.
• 5422 unchanged lines in 74 files lost coverage.
• Overall coverage decreased (-3.4%) to 61.274%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/recursordist/filterpo.hh	0	1	0.0%
pdns/recursordist/syncres.cc	5	7	71.43%
pdns/recursordist/rec-main.cc	0	6	0.0%

Files with Coverage Reduction	New Missed Lines	%
pdns/webserver.hh	1	69.16%
pdns/recursordist/ext/protozero/include/protozero/config.hpp	1	0.0%
ext/json11/json11.cpp	1	64.49%
modules/gpgsqlbackend/gpgsqlbackend.cc	1	88.62%
pdns/recursordist/sortlist.hh	1	75.0%
pdns/iputils.hh	1	76.61%
pdns/dnstap.cc	2	68.82%
ext/probds/murmur3.cc	2	88.24%
pdns/dnsdistdist/dnsdist-crypto.cc	2	75.72%
pdns/dnsname.hh	2	91.52%

Totals
Change from base Build 10939216509:	-3.4%
Covered Lines:	119185
Relevant Lines:	162007

---

💛 - Coveralls

[omoerbeek]

BTW, the RPZ regression test failures are happening because they use forwarding, which with this PR are no longer subjected to RPZ policies. If we decide the 2nd commit is there to stay, we need to adapt the tests.