Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnf sbom: handle arch absence #14698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Sep 20, 2024

Short description

fixes the breakage introduced in #14691

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie
Copy link
Member Author

Habbie commented Sep 20, 2024

non-release dnsdist (because auth builds don't use the extra json args) test build at https://github.com/Habbie/pdns/actions/runs/10963274205

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10963070747

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+3.4%) to 64.654%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-crypto.cc 2 75.72%
pdns/sstuff.hh 2 56.83%
modules/lmdbbackend/lmdbbackend.cc 2 73.46%
pdns/dnsdistdist/dnsdist.cc 2 68.36%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/stubresolver.cc 3 77.58%
pdns/recursordist/aggressive_nsec.cc 4 66.1%
pdns/packethandler.cc 4 72.47%
pdns/recursordist/syncres.cc 5 79.36%
pdns/signingpipe.cc 5 84.99%
Totals Coverage Status
Change from base Build 10961070589: 3.4%
Covered Lines: 124759
Relevant Lines: 162212

💛 - Coveralls

@Habbie
Copy link
Member Author

Habbie commented Sep 20, 2024

fake dnsdist release build https://github.com/Habbie/pdns/actions/runs/10964295787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants