Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Backport 14628 to rec 5.1.x: rec: avoid duplicated waiter ids for chained requests #14773

Merged

Conversation

omoerbeek
Copy link
Member

Short description

Backport of #14628

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

We do rely on that OS queueing the UDP packets, hope it will do so long enough

(cherry picked from commit 44b1de9)
@omoerbeek omoerbeek added this to the rec-5.1.x milestone Oct 15, 2024
@coveralls
Copy link

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build 11347194459

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 73 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.06%) to 66.34%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/remote_logger.cc 3 52.68%
pdns/iputils.cc 6 33.95%
pdns/recursordist/rec-tcpout.cc 6 50.79%
pdns/recursordist/syncres.cc 10 79.57%
pdns/recursordist/taskqueue.cc 11 34.15%
pdns/recursordist/rec-taskqueue.cc 34 40.14%
Totals Coverage Status
Change from base Build 11161224661: -0.06%
Covered Lines: 56857
Relevant Lines: 75723

💛 - Coveralls

@omoerbeek omoerbeek merged commit 0c97e15 into PowerDNS:rel/rec-5.1.x Oct 24, 2024
45 checks passed
@omoerbeek omoerbeek deleted the backport-14628-to-rec-5.1.x branch October 24, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants