Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: actively deprecate old style settings #14809

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

omoerbeek
Copy link
Member

Short description

Disable old-style parsing by default. Enable (on the command line) with --enable-old-style.
Probably will cause some grumblings, but so be it.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added the rec label Oct 29, 2024
@omoerbeek omoerbeek added this to the rec-5.2.0 milestone Oct 29, 2024
@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11663936347

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 2 files are covered.
  • 32 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.004%) to 64.643%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/recursordist/rec_channel_rec.cc 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/rec-tcpout.cc 2 63.49%
pdns/recursordist/lwres.cc 2 69.66%
modules/lmdbbackend/lmdbbackend.cc 2 73.53%
pdns/rcpgenerator.cc 2 89.59%
pdns/recursordist/settings/cxxsettings-generated.cc 2 91.62%
pdns/iputils.cc 3 55.91%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/recursordist/syncres.cc 3 79.48%
pdns/recursordist/recpacketcache.hh 3 89.55%
Totals Coverage Status
Change from base Build 11663498636: 0.004%
Covered Lines: 124779
Relevant Lines: 162252

💛 - Coveralls

@omoerbeek
Copy link
Member Author

Rebased to fix conflict in upgrade.rst

pdns/recursordist/docs/upgrade.rst Outdated Show resolved Hide resolved
pdns/recursordist/rec_channel_rec.cc Outdated Show resolved Hide resolved
@omoerbeek omoerbeek merged commit 43fd49b into PowerDNS:master Nov 4, 2024
78 checks passed
@omoerbeek omoerbeek deleted the rec-deprecate-old-style branch November 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants