Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: fix coverity 1564914 (afaiks harmless) #14834

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Nov 11, 2024

Short description

The coverity report is about zoneIdx, but it is always initialized in rec-main.cc before being used. Still having no initialized fields is better in general.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added the rec label Nov 11, 2024
@omoerbeek omoerbeek added this to the rec-5.2.0 milestone Nov 11, 2024
@coveralls
Copy link

coveralls commented Nov 11, 2024

Pull Request Test Coverage Report for Build 11774792569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 11 files lost coverage.
  • Overall coverage remained the same at 64.659%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.57%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/syncres.cc 1 79.55%
modules/lmdbbackend/lmdbbackend.cc 2 73.45%
pdns/misc.cc 2 63.49%
pdns/iputils.cc 3 54.99%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/backends/gsql/gsqlbackend.hh 3 96.57%
pdns/remote_logger.cc 3 53.81%
pdns/recursordist/rec-tcp.cc 4 64.63%
Totals Coverage Status
Change from base Build 11737481821: 0.0%
Covered Lines: 125719
Relevant Lines: 163585

💛 - Coveralls

@omoerbeek omoerbeek merged commit eaf5b9c into PowerDNS:master Nov 11, 2024
78 checks passed
@omoerbeek omoerbeek deleted the rec-coverity-20241111 branch November 11, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants