Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost > std optional #14970

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

boost > std optional #14970

wants to merge 4 commits into from

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Dec 13, 2024

I have:

@coveralls
Copy link

coveralls commented Dec 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12323094430

Details

  • 17 of 19 (89.47%) changed or added relevant lines in 4 files are covered.
  • 79 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.02%) to 64.759%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/geoipbackend/geoipbackend.cc 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.4%
ext/json11/json11.cpp 1 64.49%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/distributor.hh 2 51.86%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/tcpiohandler.cc 2 68.18%
pdns/misc.cc 2 64.45%
pdns/tsigverifier.cc 3 77.22%
pdns/recursordist/syncres.cc 3 79.54%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
Totals Coverage Status
Change from base Build 12316427950: -0.02%
Covered Lines: 125890
Relevant Lines: 163537
💛 - Coveralls

@neheb neheb force-pushed the jj branch 3 times, most recently from 0c6ee73 to fe4a54e Compare December 13, 2024 20:34
miodvallat
miodvallat approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

rgacogne
rgacogne approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few of StatNode's properties are exposed to Lua, but StatNode::submit() isn't, so I think this is OK.

@rgacogne rgacogne requested a review from Habbie December 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miodvallat miodvallat miodvallat approved these changes

@rgacogne rgacogne rgacogne approved these changes

@Habbie Habbie Awaiting requested review from Habbie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neheb @coveralls @rgacogne @miodvallat