Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add DoH3 headers, query string, path and scheme bindings #15002

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rgacogne
Copy link
Member

Short description

The DoH ones have been there for a long time, but the DoH3 ones were missing. Note that we still don't have the ability to set a HTTP response for DoH3 queries (including response maps) and SNI is still missing (Quiche does not make that last one easy).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The DoH ones have been there for a long time, but the DoH3 ones were
missing. Note that we still don't have the ability to set a HTTP
response for DoH3 queries (including response maps) and SNI is still
missing (Quiche does not make that last one easy).
@rgacogne rgacogne force-pushed the ddist-doh3-bindings branch from 4541c12 to 6c41945 Compare December 30, 2024 15:02
@coveralls
Copy link

coveralls commented Dec 30, 2024

Pull Request Test Coverage Report for Build 12549052014

Details

  • 128 of 139 (92.09%) changed or added relevant lines in 5 files are covered.
  • 7617 unchanged lines in 147 files lost coverage.
  • Overall coverage increased (+2.2%) to 64.851%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/test-dnsdisttcp_cc.cc 0 2 0.0%
pdns/dnsdistdist/dnsdist-lua-ffi.cc 44 48 91.67%
pdns/dnsdistdist/doh3.cc 33 38 86.84%
Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-session-cache.cc 1 62.86%
pdns/auth-catalogzone.hh 1 66.67%
pdns/dnsdistdist/test-dnsdistrules_cc.cc 1 95.15%
pdns/recursordist/nod.hh 1 92.59%
pdns/dnsdistdist/dnsdist-crypto.cc 1 76.01%
pdns/test-dnsrecords_cc.cc 2 95.97%
pdns/dnsdistdist/test-dnsdist-lua-ffi.cc 2 99.59%
pdns/epollmplexer.cc 2 85.0%
pdns/json.cc 2 83.33%
pdns/recursordist/rec-tcpout.cc 2 63.49%
Totals Coverage Status
Change from base Build 12508806594: 2.2%
Covered Lines: 126213
Relevant Lines: 163857

💛 - Coveralls

Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants