EDNS0 padding support in auth #15009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12667063404Details
💛 - Coveralls |
miodvallat
force-pushed
the
pad_me_harder
branch
from
2751ed0 to
1ad46e8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
miodvallat
force-pushed
the
pad_me_harder
branch
from
1ad46e8 to
304980c
Compare
Note that the typoed number (8647) was never issued as an RFC, so we might want to pretend it was our doing, so as not to make these comments too wrong.
When constructing the response to a query with EDNS0 padding set, keep this in mind and build proper EDNS0 padding in the response packet.
miodvallat
force-pushed
the
pad_me_harder
branch
from
63fd053 to
3bdc59d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Even though the auth<->recursor communication can probably be considered trustworthy, the auth server should nevertheless respond to queries containing the EDNS0 padding option with a similarly padded response. This PR achieves this.
(still marked as draft as I need to work on tests - I only checked the output of simpledigqueries with and without+padding=128)Checklist
I have: