Skip to content

Commit

Permalink
dont return empty array
Browse files Browse the repository at this point in the history
Signed-off-by: Nitish Bharambe <[email protected]>
  • Loading branch information
nitbharambe committed Jul 25, 2024
1 parent ccc6089 commit ad51a78
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/power_grid_model_io/converters/tabular_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ def _convert_table_to_component(

if "filters" in attributes:
table_mask = self._parse_table_filters(data=data, table=table, filtering_functions=attributes["filters"])
if table_mask is not None and not table_mask.any():
return None
else:
table_mask = None

Expand Down
24 changes: 24 additions & 0 deletions tests/unit/converters/test_tabular_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,30 @@ def test_convert_table_to_component__filters(
)


def test_convert_table_to_component__filters_all_false(
converter: TabularConverter, tabular_data_no_units_no_substitutions: TabularData
):
converter._convert_col_def_to_attribute = MagicMock()
converter._parse_table_filters = MagicMock()
converter._parse_table_filters.side_effect = np.array([False, False])
node_attributes_with_filter = {"id": "id_number", "u_rated": "u_nom", "filters": [{"test_fn": {}}]}
converter._convert_table_to_component(
data=tabular_data_no_units_no_substitutions,
data_type="input",
table="nodes",
component="node",
attributes=node_attributes_with_filter,
extra_info=None,
)

converter._parse_table_filters.assert_called_once_with(
data=tabular_data_no_units_no_substitutions,
table="nodes",
filtering_functions=node_attributes_with_filter["filters"],
)
converter._convert_col_def_to_attribute.assert_not_called()


def test_convert_col_def_to_attribute(
converter: TabularConverter,
tabular_data_no_units_no_substitutions: TabularData,
Expand Down

0 comments on commit ad51a78

Please sign in to comment.