Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black jupyter precommit #270

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Black jupyter precommit #270

merged 2 commits into from
Aug 23, 2024

Conversation

nitbharambe
Copy link
Member

Black can format jupyter notebooks too. Hence added it to pre-commit

Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Copy link

sonarcloud bot commented Aug 21, 2024

Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add it to the pyproject toml [docs] optional dependencies? If not, that's also fine with me

@nitbharambe
Copy link
Member Author

Should we also add it to the pyproject toml [docs] optional dependencies? If not, that's also fine with me

I dont think so. Its not a "dependency" as such.

@nitbharambe nitbharambe added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 11e5326 Aug 23, 2024
25 checks passed
@nitbharambe nitbharambe deleted the feature/jupyter-black-precommit branch August 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants