Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Namespace, and Prost Chain Id Selection from Environment #46

Merged
merged 11 commits into from
Nov 28, 2023
Merged

Dynamic Namespace, and Prost Chain Id Selection from Environment #46

merged 11 commits into from
Nov 28, 2023

Conversation

xadahiya
Copy link
Member

@xadahiya xadahiya commented Nov 28, 2023 •
edited
Loading

Changes:

  • Dynamically pick namespace from the environment, defaulting to "uniswapv2" if not present.
  • Dynamically pick prost-chain-id from the environment, defaulting to "103" if not present.

@xadahiya xadahiya changed the title Dynamic UNISWAPV2 Namespace Selection from Environment Dynamic Namespace, and Prost Chain Id Selection from Environment Nov 28, 2023
anomit
anomit approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@anomit anomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xadahiya xadahiya merged commit 5d39e16 into main Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomit anomit anomit approved these changes

@SwaroopH SwaroopH Awaiting requested review from SwaroopH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xadahiya @anomit @SwaroopH @swagftw