Use interactive browser as the fallback for non azure cli users #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzelin007
approved these changes
Nov 7, 2024
wyunchi-ms
force-pushed
the
wyunchi/fallback-to-InteractiveBrowser
branch
from
5d0072c to
0c3429c
Compare
daxian-dbw
reviewed
Nov 7, 2024
| @@ -386,7 +387,8 @@ internal async Task CreateOrRenewTokenAsync(CancellationToken cancellationToken) | |||
|
|
|||
| if (needRefresh) | |||
| { | |||
| _accessToken = await new AzureCliCredential() | |||
| _accessToken = await new ChainedTokenCredential(new AzureCliCredential(), | |||
| new InteractiveBrowserCredential(ApplicationId)) | |||
There was a problem hiding this comment.
This is a good idea, but we will need to do a lot more:
- What about scenarios where browser is not available? Like when user is using AIShell on a remote machine via SSH connection. How do we detect that and switch to "device code" login?
- The error handling (e.g. error messages to help with mitigation) regarding access token failures will need to be updated accordingly.
- Maybe we should not recommend
/replacewhen AzCLI is not installed. And we shouldn't recommend/code postfor AzCLI commands when it's not installed.
I think we should revisit this post public preview, and will definitely need to involve PMs to think about the scenarios when AzCLI is not installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those users who doesn't logined with azure cli, use interactive browse as a fallback way to get user access token.
PR Summary
PR Context