-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #242 - Adds support for PSCustomObject #243
base: main
Are you sure you want to change the base?
Conversation
- Move to new folder - Make interface and abstract base with generics - Add implementation for PSObject@
@andyleejordan this is ready for review if you are able to find time 🚀 |
@tznind We need to fix this in |
Ah, no I did not look at the ocgv command. I did create a helper though shouldn't be too hard to port across. I can probably take a look at the weekend. |
@tig I have looked into the ocgv implementation and do not think it will have the same issues that the tree view had (that this PR corrects). ocgv uses Both of the below look like correct behaviours to me, see example json
|
Does this enhancement also handle the scenario of real .NET objects like Here is an example with
|
PR Summary
Adds support for dealing with native PSObject instances (current code only deals with native object types).
Fixes #242
Test JSON
Test JSON 2
Test JSON 2 loaded in Show-ObjectTree
How to manually test with the above JSON
A new pwsh window is launched to avoid conflict of modules. Exit after test with
exit
.PR Context