-
Notifications
You must be signed in to change notification settings - Fork 205
Link GroupPolicyDsc resource #478
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @corydwood)
a discussion (no related file):
Please see the steps here:
https://github.com/PowerShell/DscResources/issues/new?template=New_resource_module_submission.md
If you could paste that into the PR description, then we can follow that list? 🙂
.gitmodules, line 196 at r1 (raw file):
path = DscResources/WmiNamespaceSecurityDsc url = https://github.com/PowerShell/WmiNamespaceSecurityDsc [submodule "DscResources/GroupPolicyDsc"]
This should have been added using git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>
, then I think there will also be a reference to module as part of the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @johlju)
a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Please see the steps here:
https://github.com/PowerShell/DscResources/issues/new?template=New_resource_module_submission.mdIf you could paste that into the PR description, then we can follow that list? 🙂
Done.
.gitmodules, line 196 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This should have been added using
git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>
, then I think there will also be a reference to module as part of the commit.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @corydwood)
a discussion (no related file):
Could you please tick off the boxes that is done in the list of the PR description?
a discussion (no related file):
Would it be possible to add the appveyor.yml template? It will use the DscResource.Test test framework when running tests, and helps tests things for HQRM (not everything, but some). https://github.com/PowerShell/DscResources/blob/master/DscResource.Template/appveyor.yml
a discussion (no related file):
Do you have aplan for deploying this module to the PS Gallery? I can't see it being deployed yet.
I of course meant with the review comment if your repo can change to the appveyor.yml template 😄 |
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
Disabled the Stale bot and changed the labels. |
I have permission on the repository, and I will see if I can get this resource in good shape for next Community call where we'll be able to reconsider this. |
As announced during the last community call, we'd love to have this as part of dsccommunity. |
Closes #101
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
in the TEMPLATE_README.md.
Tests.Template folder.
This change is
New resource module submission
Name: GroupPolicyDsc
Repository URL: https://github.com/corydwood/GroupPolicyDsc
Short description: This module contains the GPInheritance, GPOImport, and GPOLink DSC resources.
New resource module submission task list
This task list can be filled in after the issue has been submitted.
Steps that pull request should include
git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>
.Community acceptance
Community reviewers: Please submit a comment on the issue for each box that are checked so the
community know who accepted the item.
The new resource module:
'Code of conduct' section in the README.md.
README.md file.
High Quality Resource Module.
Submission acceptance
The community accepts, at a community call, that a resource module follows the
guidelines set out for a
High Quality Resource Module.