Provide more intuitive error message when JFrog feed is inactive #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerickson
requested changes
Oct 2, 2023
src/code/V3ServerAPICalls.cs
Outdated
| errRecord = new ErrorRecord( | ||
| exception: e, | ||
| "GetResponsesFromRegistrationsResourceFailure", | ||
| if (e.Message.Contains("'<' is an invalid start of a value")) |
There was a problem hiding this comment.
Is there anyway we can check the response so that if it can catch malformed responses more generically? Like using JsonDocument.TryParse() and throwing recording an error if that fails?
There was a problem hiding this comment.
Also can we check what the type of the exception is. That might be helpful too.
… scenario" This reverts commit e165ad9.
alerickson
approved these changes
Oct 4, 2023
adityapatwardhan
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
Resolves #1424
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.