Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: get Linux build to upload build artifacts #1293

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JamesWTruher
Copy link
Contributor

PR Summary

get Linux build to upload build artifacts
Add additional output to assist with debugging if there is a problem

PR Checklist

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor changes need to be done before the merge. Thanks for investigating and fixing it

else {
$dotnet = "dotnet"
}
& $dotnet publish -f $Framework -c $Configuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this the fix for the premature build abortion

#if ($IsLinux)
#{
# $expectedNumRules = 4
#}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just delete those commented out code lines now that it works without a special case (not sure why, I guess some upstream dependency received a fix)

# PowerShellEdition: WindowsPowerShell
# - APPVEYOR_BUILD_WORKER_IMAGE: WMF 4
# PowerShellEdition: WindowsPowerShell
# PSVersion: 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncomment again before the merge

if ( $LASTEXITCODE -ne 0 ) {
$buildOutput | Write-Verbose -Verbose
throw "$buildOutput"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation of closing brace is 1 level too much

Write-Verbose -Verbose "bootstrap complete: $(get-date)"
}
catch {
Write-Warning "error in invocation of build.ps1 from Invoke-AppVeyorInstall"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why catch the error and not let it error out?

@bergmeister
Copy link
Collaborator

Close and re-open to retrigger CI to check this still works

@bergmeister bergmeister reopened this Aug 22, 2019
@bergmeister bergmeister mentioned this pull request Aug 22, 2019
5 tasks
@bergmeister
Copy link
Collaborator

@JamesWTruher Shall we close this one as #1320 has the essential bits of this PR (fixing the build and uploading the tests work now again), the only thing that this PR would add are the additional verbose logs

@bergmeister
Copy link
Collaborator

Although the recently merged PR fixed the Ubuntu build it seems that it has lasted only a few days as AppVeyor updated their image with breaking changes again, will close and re-open to see if this branch is any different

@bergmeister bergmeister reopened this Aug 30, 2019
@rjmholt rjmholt marked this pull request as draft April 21, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants