Add SSH client package to community-stable images #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDIL
suggested changes
Jul 22, 2020
| @@ -13,6 +13,9 @@ ARG PS_PACKAGE=powershell-${PS_VERSION}-1.rhel.7.x86_64.rpm | |||
| ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE} | |||
| ARG PS_INSTALL_VERSION=7 | |||
|
|
|||
| # Download the PowerShell Core Linux .rpm and save it | |||
| ADD ${PS_PACKAGE_URL} /tmp/powershell-linux.rpm | |||
There was a problem hiding this comment.
Why did you revert this? It improved the image size.
There was a problem hiding this comment.
Actually, I forgotten about the layer size issue since I was helping on some work requirement for standardising syntax. lol.
ghost
added
the
TravisEz13
approved these changes
Jul 22, 2020
|
Conflicts need to be resolved. Ping me if you need me to do it. |
|
I need to close off this pull request for now as I also noticed there is an issue with OracleLinux too since it was put into unstable folder. Its bit late at my time now so can't be fixing it. I didn't realise there changes while I was in any own branch fixing the SSH for various distros. Will come back again in another PR. |
|
Pull Request superseded by #465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
sshto images #374 enhancement request for community-stable images.In order to use
Enter-PSSessionto connect with other (Windows or Linux) VM and Container,OpenSSHclient package is required.Below is the list of
OpenSSHclient package required for various linux distros:openssh-clientspackage for Amazon Linuxopensshpackage for ArchLinuxopensshpackage for BlackArchopenssh-clientpackage for ClearLinuxopenssh-clientpackage for KaliLinuxopenssh-clientspackage for Oracle Linuxopenssh-clientpackage for ParrotSecopenssh-clientspackage for PhotonRemove the need of using
wgetorcurlto download PowerShell package in DockerRUN. Use DockerADDto download PowerShell package instead.Other minor fixes
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.