Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Design #273

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/comment-on-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ jobs:
comment:
runs-on: ubuntu-latest
steps:
- name: Comment on Issue
if: github.event.issue.user.login != github.event.repository.owner.login
uses: actions/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const issueComment = `
🎉 Thanks for raising an issue 🚀
- name: Comment on Issue
if: github.event.issue.user.login != github.event.repository.owner.login
uses: actions/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const issueComment = `
🎉 Thanks for raising an issue 🚀

The maintainer will be on the case shortly to review your issue. If everything checks out, they'll assign the issue to you. 📋✅
The maintainer will be on the case shortly to review your issue. If everything checks out, they'll assign the issue to you. 📋✅

Your support means the world to us! 🌟 Please consider giving our repository a star ⭐ to show your appreciation 🚀
Your support means the world to us! 🌟 Please consider giving our repository a star ⭐ to show your appreciation 🚀

Feel free to reach out if you have any questions or need further assistance. 🙌
`;
github.issues.createComment({ issue_number: github.context.issue.number, owner: github.context.repo.owner, repo: github.context.repo.repo, body: issueComment });
Feel free to reach out if you have any questions or need further assistance. 🙌
`;
github.issues.createComment({ issue_number: github.context.issue.number, owner: github.context.repo.owner, repo: github.context.repo.repo, body: issueComment });
26 changes: 13 additions & 13 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ jobs:
comment:
runs-on: ubuntu-latest
steps:
- name: Comment on Issue
if: github.event.issue.user.login != github.event.repository.owner.login
uses: actions/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const issueComment = `
🎉 Thanks for raising an issue 🚀
- name: Comment on Issue
if: github.event.issue.user.login != github.event.repository.owner.login
uses: actions/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const issueComment = `
🎉 Thanks for raising an issue 🚀

The maintainer will be on the case shortly to review your issue. If everything checks out, they'll assign the issue to you. 📋✅
The maintainer will be on the case shortly to review your issue. If everything checks out, they'll assign the issue to you. 📋✅

Your support means the world to us! 🌟 Please consider giving our repository a star ⭐ to show your appreciation 🚀
Your support means the world to us! 🌟 Please consider giving our repository a star ⭐ to show your appreciation 🚀

Feel free to reach out if you have any questions or need further assistance. 🙌
`;
github.issues.createComment({ issue_number: github.context.issue.number, owner: github.context.repo.owner, repo: github.context.repo.repo, body: issueComment });
Feel free to reach out if you have any questions or need further assistance. 🙌
`;
github.issues.createComment({ issue_number: github.context.issue.number, owner: github.context.repo.owner, repo: github.context.repo.repo, body: issueComment });
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: Test
on:
# Triggers the workflow on push or pull request events but only for the main branch
push:
branches: [ main ]
branches: [main]
pull_request:
branches: [ main ]
branches: [main]

# Allows running this workflow manually from the Actions tab
workflow_dispatch:
Expand Down
30 changes: 19 additions & 11 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,44 +2,52 @@

Contributing to this project is a great way to get involved in open source! Here's how you can contribute:

## Fork the Repository:
## Fork the Repository:

Click the "Fork" button at the top right corner of this repository page to create your copy of the project.
![FORK](https://github.com/Prajwal0225/My-Favorite-SuperHero/assets/103810119/909b3989-25a2-47dc-9812-d534d52efd1b)

## Clone the Repository:
## Clone the Repository:

![CLONE](https://github.com/Prajwal0225/My-Favorite-SuperHero/assets/103810119/dd7346f1-9c54-4da1-832d-3e2633a40f6d)
Clone your forked repository to your local machine using the following command:

```bash
git clone "url-you-just-copied"
```

## Create a Branch:

## Create a Branch:
Navigate to the project directory and create a new branch for your contribution using:

```bash
cd My-Favorite-SuperHero
git switch -c your-new-branch-name
```

## Make Necessary Changes:
Make the desired changes to the project.
## Make Necessary Changes:

Make the desired changes to the project.

---
### Commit Changes:

### Commit Changes:

Commit your changes with a descriptive commit message using:
git commit -m "what changes you make"

### Push Changes to GitHub:
### Push Changes to GitHub:

Push your changes to your forked repository on GitHub using:
git push -u origin your-branch-name

### Create a Pull Request:
Go to the original repository on GitHub and click on the "New Pull Request" button. Provide a clear description of your changes and submit the pull request.
### Create a Pull Request:

### Review and Merge:
Your pull request will be reviewed by the project maintainers. Once approved, your changes will be merged into the main project.
Go to the original repository on GitHub and click on the "New Pull Request" button. Provide a clear description of your changes and submit the pull request.

### Review and Merge:

Your pull request will be reviewed by the project maintainers. Once approved, your changes will be merged into the main project.

Congratulations! You've successfully contributed to this project. Thank you for your contribution and for being a part of the open-source community!

Expand Down
20 changes: 6 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Hacktoberfest 2023

Hacktoberfest is DigitalOcean’s annual event that encourages people to contribute to open source throughout October. Much of modern tech infrastructure-including some of DigitalOcean’s own products-relies on open-source projects built and maintained by passionate people who often don’t have the staff or budgets to do much more than keep the project alive. Hacktoberfest is all about giving back to those projects, sharpening skills, and celebrating all things open source, especially the people that make open source so special.
For the past 10 years, thousands of people-coders and non-coders alike-have participated in Hacktoberfest to support the projects they use and love, learn and practice skills that will enhance their careers, and meet new people who love open source as much as they do.

![WhatsApp Image 2023-10-07 at 10 01 52_3e088db0](https://github.com/madhurafulkar/My-Favorite-SuperHero/assets/120560129/63bf5080-36a6-49e3-baaf-6f43fa2e66c1)

Contributions to this repository will count towards Hacktoberfest participation this year.


# Welcome to My-Favorite-SuperHero

![image](https://github.com/Prajwal0225/My-Favorite-SuperHero/assets/103810119/b7a7c61d-fcf7-4882-9420-7747f4c4577b)
Expand All @@ -17,19 +17,18 @@ Welcome to the My Fav Superhero project! This web application allows you to sear

You can see a live demo of the project here: [My Fav Superhero Demo](https://prajwal0225.github.io/My-Favorite-SuperHero/)


## 🙌 Features

- **Search Superheroes**: Enter the name of your favorite superhero, and the website will display the superhero's image along with some basic information.

- **Random Superhero**: Click the "Random" button to discover random superhero images and learn about heroes you might not have known before.

## ⚡Tech Stack Used

![HTML5](https://img.shields.io/badge/html5-%23E34F26.svg?style=for-the-badge&logo=html5&logoColor=white)
![CSS3](https://img.shields.io/badge/css3-%231572B6.svg?style=for-the-badge&logo=css3&logoColor=white)
![JavaScript](https://img.shields.io/badge/javascript-%23323330.svg?style=for-the-badge&logo=javascript&logoColor=%23F7DF1E)


## 🚀 Getting Started

To use the My Fav Superhero project, simply open the `index.html` file in your web browser. There's no need for complex setup or dependencies.
Expand All @@ -38,34 +37,30 @@ To use the My Fav Superhero project, simply open the `index.html` file in your w

```bash
git clone https://github.com/Prajwal0225/My-Favorite-SuperHero.git
```

- Open the index.html file in your preferred web browser.

- Start searching for your favorite superheroes or enjoy random hero discoveries.



https://github.com/Prajwal0225/My-Favorite-SuperHero/assets/103810119/6aae0cbc-c912-47ed-9e62-94abf60a7267



If you want to contribute to this project then check out [CONTRIBUTING.md](CONTRIBUTING.md) file.
## Issue Assignment Guidelines and Collaboration Process 📌

## Issue Assignment Guidelines and Collaboration Process 📌

- 📝 Issue Assignment: Before you start working on any issues, please make sure that the issue is assigned to you. If it's a new issue, create one if it doesn't already exist. 📌

- 👤 One person will be assigned one issue at a time. When you raise a pull request for that issue, only then can you create the next issue. Work on one issue at a time, and once the pull request for that issue gets merged, you can create another issue. This approach allows maximum contributors to have a chance to contribute, resulting in more work being done on the repository. 🏃‍♂

- 🚫 Avoid Direct PRs: Refrain from creating direct pull requests (PRs) for issues that are already assigned to someone else. This helps prevent duplicated efforts and keeps our work organized. Even if an issue is not assigned to anyone, you should create the issue first. Only when a maintainer assigns it to you, you can then raise a PR. 🚧

- 👉Please submit a pull request within 2 to 3 days after you have been assigned an issue. 😊 Failure to do so may result in the reassignment of the issue to another contributor. 🔄

- 🤝 Collaboration: If you find that an issue is already assigned to someone and you're interested in working on it, feel free to comment on the issue. If the first assigned person isn't able to complete the task or doesn't create a PR, we can reassign the issue to ensure it's addressed properly. Normally, we assign the issue to the person who created it. If they are not interested in working on it, we assign it to someone who is interested. You can comment if you want to work on it. 💬

Your cooperation is greatly appreciated, and it helps us maintain an efficient and collaborative development process. 🙌 Happy coding! 🚀


## Project Maintainers
## Project Maintainers

<table>
<tr>
Expand All @@ -87,6 +82,3 @@ Your cooperation is greatly appreciated, and it helps us maintain an efficient a
</h3>

<a href = "#top"> Back to top</a>



Loading
Loading