Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide button #47

Merged
merged 2 commits into from
Jan 22, 2024
Merged

guide button #47

merged 2 commits into from
Jan 22, 2024

Conversation

ayann07
Copy link
Contributor

@ayann07 ayann07 commented Jan 19, 2024

Pull Request
Related Issues: [List any related issues or reference them using the syntax #issue_number.]

Fixes #(issue number)
Issue Number : #16 is now fixed
Description: [Provide a brief description of your changes.]
I have created guide button for all the sections.
Checklist:

[yes] I have tested my changes.
[yes] My code follows the project's coding standards.
I have updated the documentation (if applicable).

Demo video:

guide.mp4

Additional information
I have worked under Social Winter Of Code 2024.
Please provide any other information that you think may be relevant to the pull request.

@PranabKumarSahoo
Copy link
Owner

Hello @ayann07,

Firstly, I'd like to extend my apologies for the delay in reviewing your pull request. I appreciate your effort.

After going through your guide button implementation, I must say you've done a great job implementing the functionality and incorporating user-friendly features.

And I noticed in your code that you've included the guidance text directly within the function for each tool section. To enhance the code modularity, you can create a separate GuideTexts.js file in a data folder within src, to store the every section's guidance text.

For example,

folderStructure

guideTextFile

buttonFunct

This approach allows you to import the text into each tool section, & helps keep the code modular and makes it easier to update the guidance text across all sections. Right!!!

BTW, Great work so far! Looking forward to more contributions.

#Good Luck!✌️

@ayann07
Copy link
Contributor Author

ayann07 commented Jan 22, 2024

I have now made the necessary which were required , please check now.

@PranabKumarSahoo
Copy link
Owner

Cool! ⭐
Good job @ayann07, Now I'm merging the PR.

Thanks for your contribution. Feel free to contribute more.


#Good Luck! ✌️

@PranabKumarSahoo PranabKumarSahoo merged commit 7b49e20 into PranabKumarSahoo:main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants