Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Nitro Type): update presence #8997

Merged
merged 12 commits into from
Dec 29, 2024
Merged

feat(Nitro Type): update presence #8997

merged 12 commits into from
Dec 29, 2024

Conversation

joerkig
Copy link
Contributor

@joerkig joerkig commented Dec 23, 2024

Description

Updated various parts of the activity due to site changes
Added showing users selected car

Resolves #8632

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

image
image
image
image

@joerkig
Copy link
Contributor Author

joerkig commented Dec 23, 2024

ugh messed up a commit one moment

@joerkig
Copy link
Contributor Author

joerkig commented Dec 23, 2024

ugh messed up a commit one moment

Okay to review now

@joerkig
Copy link
Contributor Author

joerkig commented Dec 23, 2024

Actually if you give a bit I'll more thoroughly add #8632

@joerkig joerkig marked this pull request as draft December 23, 2024 16:08
@joerkig joerkig marked this pull request as ready for review December 23, 2024 16:45
Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the rest LGTM

websites/N/Nitro Type/presence.ts Outdated Show resolved Hide resolved
@joerkig joerkig requested a review from Bas950 December 29, 2024 13:36
@theusaf theusaf merged commit 3867b54 into PreMiD:main Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Nitro Type | nitrotype.com - add user placements in leagues
3 participants