Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove spaces from strings and delete: V Live Presence #9033

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

darkvillager2
Copy link
Contributor

Description

Goes with PreMiD/Localization#7567

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected n/a

@darkvillager2 darkvillager2 changed the title chore: remove spaces from string names chore: remove spaces from strings and delete: V Live Presence Dec 29, 2024
@theusaf theusaf added activity update activity deletion multiple activities PR edits more than 1 activity repo maintenance General repo maintenance, including updating tools etc labels Dec 29, 2024
@theusaf theusaf requested a review from Bas950 December 29, 2024 23:33
Copy link
Member

@Timeraa Timeraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to hold off on this one until we update the apis & translation updater otherwise users won't ever get it returned. Besides there are more activities with this issue like Apple Music.

Requesting changes to block this from being merged until these are solved.

@Timeraa Timeraa merged commit c61a68c into PreMiD:main Jan 2, 2025
2 of 3 checks passed
@darkvillager2 darkvillager2 deleted the spaces-string-names branch January 2, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activity deletion activity update multiple activities PR edits more than 1 activity repo maintenance General repo maintenance, including updating tools etc
Development

Successfully merging this pull request may close these issues.

3 participants