feat: add extraArgs to deployment's args field (#276)

add extraArgs to charts Co-authored-by: Jamie Zieziula <[email protected]>
PrefectHQ · Dec 12, 2023 · 18c238a · 18c238a
1 parent e02e2c7
commit 18c238a
Show file tree

Hide file tree

Showing 11 changed files with 41 additions and 4 deletions.
diff --git a/charts/prefect-agent/README.md b/charts/prefect-agent/README.md
@@ -46,6 +46,7 @@ Prefect Agent application bundle
 | agent.containerSecurityContext.readOnlyRootFilesystem | bool | `true` | set agent containers' security context readOnlyRootFilesystem |
 | agent.containerSecurityContext.runAsNonRoot | bool | `true` | set agent containers' security context runAsNonRoot |
 | agent.containerSecurityContext.runAsUser | int | `1001` | set agent containers' security context runAsUser |
+| agent.extraArgs | list | `[]` | array with extra Arguments for the agent container to start with |
 | agent.extraContainers | list | `[]` | additional sidecar containers |
 | agent.extraEnvVars | list | `[]` | array with extra environment variables to add to agent nodes |
 | agent.extraEnvVarsCM | string | `""` | name of existing ConfigMap containing extra env vars to add to agent nodes |

diff --git a/charts/prefect-agent/templates/deployment.yaml b/charts/prefect-agent/templates/deployment.yaml
@@ -81,6 +81,9 @@ spec:
             - --limit
             - {{ .Values.agent.config.limit | quote }}
             {{- end }}
+            {{- range .Values.agent.extraArgs }}
+            - {{ . | toString }}
+            {{- end }}
           workingDir: /home/prefect
           env:
             - name: HOME

diff --git a/charts/prefect-agent/values.yaml b/charts/prefect-agent/values.yaml
@@ -155,6 +155,9 @@ agent:
   # -- array with extra volumeMounts for the agent pod
   extraVolumeMounts: []
 
+  # -- array with extra Arguments for the agent container to start with
+  extraArgs: []
+
 ## ServiceAccount configuration
 serviceAccount:
   # -- specifies whether a ServiceAccount should be created

diff --git a/charts/prefect-server/README.md b/charts/prefect-server/README.md
@@ -40,6 +40,7 @@ If you are installing the chart as-is (and therefore installing PostgreSQL) - yo
 
     2. `password`: the same password defined in the `connection-string` above
 
+
 Two secrets are created when not providing an existing secret name:
 1. `prefect-server-postgresql-connection`: used by the prefect-server deployment to connect to the postgresql database.
 
@@ -145,6 +146,7 @@ No secrets are created when providing an existing secret.
 | server.containerSecurityContext.runAsUser | int | `1001` | set server containers' security context runAsUser |
 | server.debug | bool | `false` | enable server debug mode |
 | server.env | list | `[]` | array with environment variables to add to server nodes |
+| server.extraArgs | list | `[]` | array with extra Arguments for the server container to start with |
 | server.extraContainers | list | `[]` | additional sidecar containers |
 | server.extraEnvVarsCM | string | `""` | name of existing ConfigMap containing extra env vars to add to server nodes |
 | server.extraEnvVarsSecret | string | `""` | name of existing Secret containing extra env vars to add to server nodes |
@@ -194,5 +196,6 @@ No secrets are created when providing an existing secret.
 | serviceAccount.create | bool | `true` | specifies whether a ServiceAccount should be created |
 | serviceAccount.name | string | `""` | the name of the ServiceAccount to use. if not set and create is true, a name is generated using the common.names.fullname template |
 
+
 ----------------------------------------------
 Autogenerated from chart metadata using [helm-docs v1.11.3](https://github.com/norwoodj/helm-docs/releases/v1.11.3)
diff --git a/charts/prefect-server/templates/deployment.yaml b/charts/prefect-server/templates/deployment.yaml
@@ -66,6 +66,9 @@ spec:
             - start
             - --port
             - {{ .Values.service.targetPort | quote }}
+            {{- range .Values.server.extraArgs }}
+            - {{ . | toString }}
+            {{- end }}
           workingDir: /home/prefect
           ports:
             - containerPort: {{ int .Values.service.targetPort }}

diff --git a/charts/prefect-server/values.schema.json b/charts/prefect-server/values.schema.json
@@ -475,6 +475,12 @@
           "items": {
             "type": "object"
           }
+        },
+        "extraArgs": {
+          "type": "array",
+          "title": "Extra Container Args",
+          "description": "array with extra args for the server container",
+          "form": true
         }
       }
     },

diff --git a/charts/prefect-server/values.yaml b/charts/prefect-server/values.yaml
@@ -169,6 +169,9 @@ server:
   # -- array with extra volumeMounts for the server pod
   extraVolumeMounts: []
 
+  # -- array with extra Arguments for the server container to start with
+  extraArgs: []
+
 ## ServiceAccount configuration
 serviceAccount:
   # -- specifies whether a ServiceAccount should be created

diff --git a/charts/prefect-worker/README.md b/charts/prefect-worker/README.md
@@ -1,5 +1,6 @@
 # prefect-worker
 
+
 ## Overview
 
 [Workers](https://docs.prefect.io/latest/concepts/work-pools/#worker-overview) are lightweight polling services that retrieve scheduled runs from a work pool and execute them.
@@ -261,6 +262,7 @@ helm install prefect-worker prefect/prefect-worker -f values.yaml --set-file wor
 | worker.containerSecurityContext.readOnlyRootFilesystem | bool | `true` | set worker containers' security context readOnlyRootFilesystem |
 | worker.containerSecurityContext.runAsNonRoot | bool | `true` | set worker containers' security context runAsNonRoot |
 | worker.containerSecurityContext.runAsUser | int | `1001` | set worker containers' security context runAsUser |
+| worker.extraArgs | list | `[]` | array with extra Arguments for the worker container to start with |
 | worker.extraContainers | list | `[]` | additional sidecar containers |
 | worker.extraEnvVars | list | `[]` | array with extra environment variables to add to worker nodes |
 | worker.extraEnvVarsCM | string | `""` | name of existing ConfigMap containing extra env vars to add to worker nodes |
@@ -298,5 +300,6 @@ helm install prefect-worker prefect/prefect-worker -f values.yaml --set-file wor
 | worker.serverApiConfig.uiUrl | string | `"http://localhost:4200"` | prefect UI url |
 | worker.tolerations | list | `[]` | tolerations for worker pods assignment |
 
+
 ----------------------------------------------
 Autogenerated from chart metadata using [helm-docs v1.11.3](https://github.com/norwoodj/helm-docs/releases/v1.11.3)
diff --git a/charts/prefect-worker/templates/deployment.yaml b/charts/prefect-worker/templates/deployment.yaml
@@ -89,6 +89,9 @@ spec:
             - --base-job-template
             - baseJobTemplate.json
             {{- end }}
+            {{- range .Values.worker.extraArgs }}
+            - {{ . | toString }}
+            {{- end }}
           workingDir: /home/prefect
           env:
             - name: HOME

diff --git a/charts/prefect-worker/values.schema.json b/charts/prefect-worker/values.schema.json
@@ -512,13 +512,13 @@
         "extraEnvVarsCM": {
           "type": "string",
           "title": "Extra Env Vars ConfigMap",
-          "description": "name of existing ConfigMap containing extra env vars to add to server nodes",
+          "description": "name of existing ConfigMap containing extra env vars to add to worker nodes",
           "form": true
         },
         "extraEnvVarsSecret": {
           "type": "string",
           "title": "Extra Env Vars Secret",
-          "description": "name of existing Secret containing extra env vars to add to server nodes",
+          "description": "name of existing Secret containing extra env vars to add to worker nodes",
           "form": true
         },
         "extraContainers": {
@@ -533,7 +533,7 @@
         "extraVolumes": {
           "type": "array",
           "title": "Extra Volumes",
-          "description": "array with extra volumes for the server pod",
+          "description": "array with extra volumes for the worker pod",
           "form": true,
           "items": {
             "type": "object"
@@ -542,11 +542,17 @@
         "extraVolumeMounts": {
           "type": "array",
           "title": "Extra Volume Mounts",
-          "description": "array with extra volumeMounts for the server pod",
+          "description": "array with extra volumeMounts for the worker pod",
           "form": true,
           "items": {
             "type": "object"
           }
+        },
+        "extraArgs": {
+          "type": "array",
+          "title": "Extra Container Args",
+          "description": "array with extra args for the worker container",
+          "form": true
         }
       }
     },

diff --git a/charts/prefect-worker/values.yaml b/charts/prefect-worker/values.yaml
@@ -201,6 +201,9 @@ worker:
   # -- array with extra volumeMounts for the worker pod
   extraVolumeMounts: []
 
+  # -- array with extra Arguments for the worker container to start with
+  extraArgs: []
+
 ## ServiceAccount configuration
 serviceAccount:
   # -- specifies whether a ServiceAccount should be created