fix: update bitnami/common dependency chart to support helm 3.2+ #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #235
applies bitnami/charts#19177
we received a community report where a user attempted to update their prefect-helm chart from
2023.09.01->2023.09.07, and seeing this error:this exception comes from the helper templates we pull in from the bitnami/common chart, specifically the
_labels.tplmodule. it turns out that the bitnami folks added a template expression with newlines in thebitnami/[email protected]chart, which isn't compatible with older versions of gotpl + helm <= 3.5.x. they've since pushed a fix for2.10.1, and i've verified this fix locally with an older version of helmthis impacts users who are on an older version of helm, but can resolve it without changing their prefect chart version if they update their helm client. for those who cannot, this PR bumps the
bitnami/commonversion to apply this backwards compatible fix