enhancement: add the ability to customize the target port of the server deployment #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
reviewed
Oct 10, 2023
| @@ -10,6 +10,10 @@ jobs: | |||
| update_helm_releases: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Sleep for 3 minutes to allow time for the helm package to be available | |||
There was a problem hiding this comment.
ouch. so the package doesn't become available on the helm registry for a bit?
There was a problem hiding this comment.
i think it just takes a minute or two
parkedwards
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows end users to customize the exposed port of the
serverdeployment. As a result, users have the ability to adjust the exposed service port without causing an issue with theserverdeploymentResolves #256