feat(base-job-template): Add base job template name #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jamiezieziula, PTAL? |
jamiezieziula
approved these changes
Dec 5, 2023
Thank you @jamiezieziula! Also, all lint and tests are failing for the same reason: Have you ran into this issue before? |
|
@lucas-koontz yes I have and of course I can't remember what the cause was. I'm fairly confident this change is safe. I'll try to fix the lint tests tomorrow but if I don't get to it I'll test locally and merge! |
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
baseJobTemplateNametoprefect-workerallowing the use of different base job templates for different workers within the same namespaces.