Prom exporter release #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimid27
commented
Dec 6, 2023
| SIGN_KEYRING: ${{ env.SIGN_KEYRING }} | ||
| SIGN_PASSPHRASE_FILE: ${{ env.SIGN_PASSPHRASE_FILE }} | ||
|
|
||
| - name: Update chart index |
There was a problem hiding this comment.
Do I need to add all charts to the index? Will something break if I don't?
There was a problem hiding this comment.
i don't think so but idk!
jamiezieziula
approved these changes
Dec 6, 2023
| # prefect-prometheus-exporter-2023.9.1, but not prefect-prometheus-exporter-2023.09.01 | ||
| # prefect-prometheus-exporter-2023.11.5, but not prefect-prometheus-exporter-2023.11.05 | ||
| # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet | ||
| - 'prefect-prometheus-exporter-2[0-9][2-9][3-9].1?[0-9].[1-3]?[0-9]' |
There was a problem hiding this comment.
this makes sense as the release name, is it also the tag name??
Also - should we convert to doing this for the other charts. i think we used to back in the day?
There was a problem hiding this comment.
Yeah I'll create an issue to do the same w/ the other charts. This is also the tag name, yes
| - https://github.com/PrefectHQ/prefect-helm | ||
| type: application | ||
| # This version is never actually shipped. github actions will package add the appropriate version at build-time | ||
| version: 0.0.0 |
There was a problem hiding this comment.
is this accurate? is the app version the docker image version or something else?
There was a problem hiding this comment.
Docker image version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefect-prometheus-exporter-