Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add chart version timestamp in the patch slot, without hyphen #300

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

parkedwards
Copy link
Contributor

so it will be:

2024.2.9125019

# instead of

2024.2.9-125019

as the pre-release append is NOT treated as part of the normal versioning sequence:

Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements

@parkedwards parkedwards requested a review from a team as a code owner February 9, 2024 20:51
@@ -21,7 +21,7 @@ jobs:
# Enable pipefail so git command failures do not result in null versions downstream
set -x

echo "RELEASE_VERSION=$(date +'%Y.%-m.%-d-%H%M%S')" >> $GITHUB_OUTPUT
echo "RELEASE_VERSION=$(date +'%Y.%-m.%-d%H%M%S')" >> $GITHUB_OUTPUT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the %H%M%S will always be 6 digits, so we can back into the "day" piece pretty consistently (6 chars from the right)

@parkedwards parkedwards merged commit 3b5f9f5 into main Feb 9, 2024
16 checks passed
@parkedwards parkedwards deleted the fix/use-timestamp-in-patch branch February 9, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants