-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional properties #317
Allow additional properties #317
Conversation
Hi @fabrice-toussaint, can you give us some more insight on the additional property that you would like to add and what it would be mapped to in your use case? |
@jamiezieziula we are trying to implement Prefect using vcluster to spin up a temporary environment. We want to be able to enable / disable specific charts (depending on the temporary environment). All other services that we use (i.e. postgres) allow us to set an additional property (i.e. enabled) so that we can include / exclude them. We also need the property to be enabled on the "highest" level, so I could exclude it from the "lower" levels. |
@@ -1,7 +1,7 @@ | |||
{ | |||
"$schema": "http://json-schema.org/schema#", | |||
"type": "object", | |||
"additionalProperties": false, | |||
"additionalProperties": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly that would work perfectly for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - appreciate you explaining your use case!
Closes #316