Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional properties #317

Merged

Conversation

fabrice-toussaint
Copy link
Contributor

@fabrice-toussaint fabrice-toussaint commented Apr 22, 2024

Closes #316

@fabrice-toussaint fabrice-toussaint requested a review from a team as a code owner April 22, 2024 14:39
@jamiezieziula
Copy link
Contributor

Hi @fabrice-toussaint, can you give us some more insight on the additional property that you would like to add and what it would be mapped to in your use case?

@fabrice-toussaint
Copy link
Contributor Author

fabrice-toussaint commented May 1, 2024

@jamiezieziula we are trying to implement Prefect using vcluster to spin up a temporary environment. We want to be able to enable / disable specific charts (depending on the temporary environment). All other services that we use (i.e. postgres) allow us to set an additional property (i.e. enabled) so that we can include / exclude them.

We also need the property to be enabled on the "highest" level, so I could exclude it from the "lower" levels.

@@ -1,7 +1,7 @@
{
"$schema": "http://json-schema.org/schema#",
"type": "object",
"additionalProperties": false,
"additionalProperties": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context this means that something like:
Screenshot 2024-05-01 at 2 48 44 PM

is great. But something like:
Screenshot 2024-05-01 at 2 49 21 PM

is still not permitted which makes sense for these use cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly that would work perfectly for us

Copy link
Contributor

@jimid27 jimid27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - appreciate you explaining your use case!

@jimid27 jimid27 merged commit 8084d34 into PrefectHQ:main May 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

additionalProperties to true
4 participants