Skip to content

Commit

Permalink
Merge pull request #2843 from PrefectHQ/update-packages
Browse files Browse the repository at this point in the history
Update vue to 3.5.x and fix breaking changes
  • Loading branch information
pleek91 authored Dec 3, 2024
2 parents aeb157e + 675f632 commit 57ffdcc
Show file tree
Hide file tree
Showing 21 changed files with 250 additions and 325 deletions.
237 changes: 125 additions & 112 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"@prefecthq/vue-charts": "^2.0.3",
"@prefecthq/vue-compositions": "^1.11.4",
"vee-validate": "^4.7.0",
"vue": "^3.4.26",
"vue": "^3.5.0",
"vue-router": "^4.3.0"
}
}
12 changes: 4 additions & 8 deletions src/components/ArtifactMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,14 @@
</p-icon-button-menu>
</template>

<script lang="ts">
export default {
name: 'ArtifactMenu',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import CopyOverflowMenuItem from '@/components/CopyOverflowMenuItem.vue'
import { Artifact, ArtifactCollection } from '@/models'
defineOptions({
inheritAttrs: false,
})
defineProps<{
artifact: Artifact | ArtifactCollection,
}>()
Expand Down
12 changes: 4 additions & 8 deletions src/components/BlockCapabilityBlockDocumentInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@
</div>
</template>

<script lang="ts">
export default {
name: 'BlockCapabilityBlockDocumentInput',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { SelectOptionGroup, useAttrsStylesClassesAndListeners } from '@prefecthq/prefect-design'
import { useSubscription, useSubscriptionWithDependencies } from '@prefecthq/vue-compositions'
Expand All @@ -48,6 +40,10 @@
import { mapper } from '@/services'
import { withQuery } from '@/utilities'
defineOptions({
inheritAttrs: false,
})
const props = defineProps<{
modelValue: string | null | undefined,
capability: string,
Expand Down
12 changes: 4 additions & 8 deletions src/components/BlockDocumentMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@
/>
</template>

<script lang="ts">
export default {
name: 'BlockDocumentMenu',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { PIconButtonMenu, POverflowMenuItem } from '@prefecthq/prefect-design'
import { useRouter } from 'vue-router'
Expand All @@ -33,6 +25,10 @@
import { BlockDocument } from '@/models'
import { deleteItem } from '@/utilities'
defineOptions({
inheritAttrs: false,
})
const props = defineProps<{
blockDocument: BlockDocument,
}>()
Expand Down
12 changes: 4 additions & 8 deletions src/components/ConcurrencyLimitMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,16 @@
<ConcurrencyLimitResetModal v-model:showModal="showResetModal" :concurrency-limit="concurrencyLimit" />
</template>

<script lang="ts">
export default {
name: 'ConcurrencyLimitsMenu',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { CopyOverflowMenuItem, ConfirmDeleteModal, ConcurrencyLimitResetModal } from '@/components'
import { useShowModal, useCan, useWorkspaceApi } from '@/compositions'
import { ConcurrencyLimit } from '@/models'
import { deleteItem } from '@/utilities'
defineOptions({
inheritAttrs: false,
})
defineProps<{
concurrencyLimit: ConcurrencyLimit,
}>()
Expand Down
12 changes: 4 additions & 8 deletions src/components/ConcurrencyLimitV2Menu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,16 @@
/>
</template>

<script lang="ts">
export default {
name: 'ConcurrencyV2LimitsMenu',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { CopyOverflowMenuItem, ConcurrencyLimitV2ResetModal, ConfirmDeleteModal, ConcurrencyLimitsV2UpdateModal } from '@/components'
import { useShowModal, useCan, useWorkspaceApi } from '@/compositions'
import { ConcurrencyV2Limit } from '@/models'
import { deleteItem } from '@/utilities'
defineOptions({
inheritAttrs: false,
})
defineProps<{
concurrencyLimit: ConcurrencyV2Limit,
}>()
Expand Down
22 changes: 6 additions & 16 deletions src/components/ConfirmDeleteModalWithSlot.vue
Original file line number Diff line number Diff line change
@@ -1,30 +1,20 @@
<template inheritAttrs="false">
<template>
<slot :show-modal="showModal" :is-open="isOpen" :open="open" :close="close" :toggle="toggle" />

<ConfirmDeleteModal v-model:showModal="showModal" v-bind="$attrs">
<template v-for="(index, name) in $slots" #[name]="data">
<slot :name="name" v-bind="data" />
</template>
</ConfirmDeleteModal>
</template>

<script lang="ts">
import { defineComponent } from 'vue'
<script lang="ts" setup>
import ConfirmDeleteModal from '@/components/ConfirmDeleteModal.vue'
import { useShowModal } from '@/compositions/useShowModal'
export default defineComponent({
name: 'ConfirmDeleteModalWithSlot',
expose: [],
components: {
ConfirmDeleteModal,
},
defineOptions({
inheritAttrs: false,
setup() {
const { showModal, isOpen, open, close, toggle } = useShowModal()
return { showModal, isOpen, open, close, toggle }
},
})
const { showModal, isOpen, open, close, toggle } = useShowModal()
</script>
12 changes: 4 additions & 8 deletions src/components/DeploymentMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,17 @@
<QuickRunParametersModal v-model:showModal="showParametersModal" :deployment="deployment" />
</template>

<script lang="ts">
export default {
name: 'DeploymentMenu',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { DeploymentQuickRunOverflowMenuItem, DeploymentCustomRunOverflowMenuItem, ConfirmDeleteModal, CopyOverflowMenuItem } from '@/components'
import QuickRunParametersModal from '@/components/QuickRunParametersModal.vue'
import { useWorkspaceApi, useWorkspaceRoutes, useShowModal } from '@/compositions'
import { Deployment } from '@/models'
import { deleteItem } from '@/utilities'
defineOptions({
inheritAttrs: false,
})
defineProps<{
deployment: Deployment,
showAll?: boolean,
Expand Down
11 changes: 3 additions & 8 deletions src/components/DeploymentScheduleMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@
/>
</template>

<script lang="ts">
export default {
name: 'DeploymentScheduleMenu',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { showToast } from '@prefecthq/prefect-design'
import { ref } from 'vue'
Expand All @@ -33,6 +25,9 @@
import { Deployment, DeploymentSchedule, DeploymentScheduleCompatible } from '@/models'
import { deleteItem } from '@/utilities'
defineOptions({
inheritAttrs: false,
})
const props = defineProps<{
deployment: Deployment,
Expand Down
12 changes: 4 additions & 8 deletions src/components/DeploymentsDeleteButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@
/>
</template>

<script lang="ts">
export default {
name: 'DeploymentsDeleteButton',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { showToast } from '@prefecthq/prefect-design'
import { computed, useAttrs } from 'vue'
Expand All @@ -24,6 +16,10 @@
import { localization } from '@/localization'
import { getApiErrorMessage } from '@/utilities/errors'
defineOptions({
inheritAttrs: false,
})
defineProps<{
selected: string[],
}>()
Expand Down
12 changes: 4 additions & 8 deletions src/components/FlowMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,17 @@
/>
</template>

<script lang="ts">
export default {
name: 'FlowMenu',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import CopyOverflowMenuItem from '@/components/CopyOverflowMenuItem.vue'
import { ConfirmDeleteModal } from '@/components/index'
import { useCan, useShowModal, useWorkspaceApi, useWorkspaceRoutes } from '@/compositions'
import { Flow } from '@/models'
import { deleteItem } from '@/utilities'
defineOptions({
inheritAttrs: false,
})
defineProps<{
flow: Flow,
}>()
Expand Down
12 changes: 4 additions & 8 deletions src/components/FlowsDeleteButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@
/>
</template>

<script lang="ts">
export default {
name: 'FlowsDeleteButton',
expose: [],
inheritAttrs: false,
}
</script>

<script lang="ts" setup>
import { showToast } from '@prefecthq/prefect-design'
import { computed, useAttrs } from 'vue'
Expand All @@ -24,6 +16,10 @@
import { localization } from '@/localization'
import { getApiErrorMessage } from '@/utilities/errors'
defineOptions({
inheritAttrs: false,
})
defineProps<{
selected: string[],
}>()
Expand Down
Loading

0 comments on commit 57ffdcc

Please sign in to comment.